Repository navigation
chore: release v24.0.0 - #8055
Merged
Merged
Conversation
Set CLIENT_VERSION_IS_RELEASE to true, archive the v23.1.10 release notes and start the v24.0.0 change log from v23.1.10, the last release before it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.
Commit d6c066f. Normal review starts when eligible; priority review starts as soon as a slot is available. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PastaPastaPasta
marked this pull request as ready for review
November 5, 2026 03:09
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
v24.0.xis atv24.0.0-rc.7(111a2c533e) and still builds as a pre-release:CLIENT_VERSION_IS_RELEASEisfalse, so the binaries show the "This is a pre-release test build" warning. The final tag needs that flag set, and the v24.0.0 release notes don't yet list v23.1.10 (released Nov 2), which shipped after the notes were written.What was done?
configure.ac: set_CLIENT_VERSION_IS_RELEASEtotrue. The version is already 24.0.0.doc/release-notes/dash/release-notes-23.1.10.md: archive the v23.1.10 notes, copied byte for byte from thev23.1.10tag.doc/release-notes.md: add v23.1.10 to "Older releases" and start the "set of changes" link fromv23.1.10instead ofv23.1.9. v23.1.10 is the last release before v24.0.0 and is an ancestor of this branch.contrib/flatpak/org.dash.dash-core.metainfo.xml: add the23.1.10entry, copied from thev23.1.10tag (2026-10-30, the date that tag recorded). The24.0.0entry dated2026-11-05was already there.Nothing else changes. Code, consensus and activation parameters, chainparams, seeds, translations and man pages are as they were at rc.7. Those were updated earlier in #7974, #7982 and #7989.
How Has This Been Tested?
git diff v24.0.0-rc.7touches only the four files above. Inconfigure.acthe only change is the_CLIENT_VERSION_IS_RELEASEline.git show v23.1.10:doc/release-notes.mdexactly (cmp).xmllint --nooutpasses on the metainfo file.202632c83con macOS with Homebrew Autoconf 2.73 (the later metainfo commit doesn't affect the build). This passed only with a local workaround, so it isn't a clean build pass:./autogen.sh && ./configuresucceeds, and the generatedsrc/config/bitcoin-config.hhas#define CLIENT_VERSION_IS_RELEASE true.make -C src dash-clifailed withbitcoin-cli.cpp:151:32: error: use of undeclared identifier 'PACKAGE_NAME'. This Autoconf leaves all sixPACKAGE_*macros as#undefin the generated header, although configure sets them inconfdefs.h.PACKAGE_*defines from configure'sconfdefs.hinto the generated, untracked header,dash-cliandwarnings.cppcompiled. No tracked file was changed.dash-cli -versionprintsDash Core RPC client version v24.0.0. The compiledwarnings.ono longer contains the "pre-release test build" string.Breaking Changes
None.
Checklist:
🤖 Generated with Claude Code